Skip to content

Fix generation of StreamingResponseTextAnnotationAddedUpdate #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix generation of StreamingResponseTextAnnotationAddedUpdate #507

merged 1 commit into from
Jul 15, 2025

Conversation

@joseharriaga
Copy link
Collaborator

@joseharriaga joseharriaga commented Jul 3, 2025

Fixes an error in code generation that caused the StreamingResponseTextAnnotationAddedUpdate class to not be generated correctly as part of the set of possible handles for streaming Responses.

@joseharriaga joseharriaga mentioned this pull request Jul 3, 2025
Closed
gaspardpetit
gaspardpetit reviewed Jul 3, 2025
View reviewed changes
gaspardpetit
gaspardpetit reviewed Jul 3, 2025
View reviewed changes
@joseharriaga joseharriaga merged commit 6a50608 into main Jul 15, 2025
1 check passed
@joseharriaga joseharriaga deleted the joseharriaga/FixStreamingResponseTextAnnotationAddedUpdate branch July 15, 2025 21:44
@ericstj
Copy link

ericstj commented Aug 5, 2025

It looks like this change removed the public constructor on StreamingResponseTextAnnotationAddedUpdate -- was that intentional?

@joseharriaga
Copy link
Collaborator Author

joseharriaga commented Aug 5, 2025

It looks like this change removed the public constructor on StreamingResponseTextAnnotationAddedUpdate -- was that intentional?

Yes, our output classes don't have public constructors by design. Is removing the constructor from StreamingResponseTextAnnotationAddedUpdate causing problems for you?

@ericstj ericstj mentioned this pull request Aug 5, 2025
Closed
@ericstj
Copy link

ericstj commented Aug 5, 2025

No, another internal breaking change broke my use of Azure.OpenAI, so I ran APICompat to see what else was broken and noticed this public breaking change.

@jsquire
Copy link
Collaborator

jsquire commented Aug 5, 2025

Worth mentioning we only consider this an acceptable change because it's on an experimental surface. We maintain strong back-compat guarantees on stable surfaces, but experimental should be expected to potentially have breaks between releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire approved these changes

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

+1 more reviewer

@gaspardpetit gaspardpetit gaspardpetit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joseharriaga @ericstj @jsquire @KrzysztofCwalina @gaspardpetit